Page MenuHomeSoftware Heritage

Introduce a KeyType alias in serializers to factor out its definition This will be helpful for further diffs.
ClosedPublic

Authored by olasd on Apr 9 2020, 2:12 PM.

Details

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D2991 (id=10630)

Could not rebase; Attempt merge onto 893d285adf...

Updating 893d285..e1ab119
Fast-forward
 swh/journal/serializers.py  |  6 ++++--
 swh/journal/writer/kafka.py | 13 +++++++------
 2 files changed, 11 insertions(+), 8 deletions(-)
Changes applied before test
commit e1ab119cc51aec0440ffaf8431e05b2e60609763
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 8 16:58:51 2020 +0200

    Introduce a KeyType alias in serializers to factor out its definition

commit 08348047d28bfd699a827f6a6b0fcf5dc8625aca
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 8 16:50:57 2020 +0200

    Accept Sequence[ModelObject] instead of List[ModelObject]
    
    The latter is invariant (because List is a mutable type), so it doesn't allow
    passing in lists of ModelObject subtypes.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/22/ for more details.

This revision is now accepted and ready to land.Apr 9 2020, 2:23 PM

Build is green

Patch application report for D2991 (id=10636)

Could not rebase; Attempt merge onto 893d285adf...

Updating 893d285..bd96649
Fast-forward
 swh/journal/serializers.py  |  6 ++++--
 swh/journal/writer/kafka.py | 13 +++++++------
 2 files changed, 11 insertions(+), 8 deletions(-)
Changes applied before test
commit bd966490570c3d07df2e3adbb81b83ef3db2aed7
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 8 16:58:51 2020 +0200

    Introduce a KeyType alias in serializers to factor out its definition

commit eb4f3626e8f3f6e0cffbc610fdd47e06ddbdac22
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Apr 8 16:50:57 2020 +0200

    write_additions: Accept Iterable[ModelObject] instead of List[ModelObject]
    
    This allows us to pass objects typed as lists of ModelObject subtypes.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/27/ for more details.