Differential D2955

Update pre-commit config to use a 'local' configuration
ClosedPublic
Actions

Authored by douardda on Apr 3 2020, 3:12 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDJNLf3112dbf7cce: Enforce current dev version of pyflakes in tox and pre-commit

Summary

This is needed to be able to use flake8 with pyflakes > 2.1.1
to gain support for @overload on methods.

Depends on D2954.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 3 2020, 3:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 3 2020, 3:12 PM

Build has FAILED

Patch application report for D2955 (id=10515)

Could not rebase; Attempt merge onto ca7e9d20c5...

Updating ca7e9d2..7e51665
Fast-forward
 .pre-commit-config.yaml       | 15 ++++++++++++++-
 setup.cfg                     |  6 ++++++
 swh/journal/tests/conftest.py |  8 ++------
 3 files changed, 22 insertions(+), 7 deletions(-)
 create mode 100644 setup.cfg

Changes applied before test

commit 7e51665eae837164342a5d49bf4cf11d861d16a7
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 14:54:25 2020 +0200

    Update pre-commit config to use a 'local' configuration
    
    This is needed to be able to use flake8 with pyflakes > 2.1.1
    to gain support for @overload on methods.

commit eb6ff79a76a470482624886b50f1b25fd8c03ad6
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 13:32:44 2020 +0200

    Add a setup.cfg to make flake8 compatible with blackified files

commit 9c697f6812899d002ee411807fe85611b163a8b7
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Apr 2 15:18:00 2020 +0200

    test: use Multihash to create a valid dict for a Content object

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/7/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/7/console

Harbormaster failed remote builds in B11605: Diff 10515!Apr 3 2020, 3:13 PM

douardda added a child revision: D2956: writer: make the writer use swh.model objects instead of (possibly) dicts.Apr 3 2020, 3:14 PM

ardumont accepted this revision.Apr 3 2020, 3:29 PM

This revision is now accepted and ready to land.Apr 3 2020, 3:29 PM

rebase + modify tox as well

Build is green

Patch application report for D2955 (id=10523)

Could not rebase; Attempt merge onto f6a398f99a...

Updating f6a398f..f3112db
Fast-forward
 .pre-commit-config.yaml | 15 ++++++++++++++-
 setup.cfg               |  6 ++++++
 tox.ini                 |  1 +
 3 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 setup.cfg

Changes applied before test

commit f3112dbf7cceed2520a1cd44d0b6701bee271dd8
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 14:54:25 2020 +0200

    Enforce current dev version of pyflakes in tox and pre-commit
    
    - Enforce installation of pyflakes from upstream git repo.
    - Update pre-commit config to use a 'local' configuration.
      This is needed to be able to use flake8 with pyflakes > 2.1.1
      to gain support for @overload on methods.

commit a25e1222aed63fa0a83df959161f98698ac15484
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 13:32:44 2020 +0200

    Add a setup.cfg to make flake8 compatible with blackified files

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B11614: Diff 10523.Apr 3 2020, 3:55 PM

Closed by commit rDJNLf3112dbf7cce: Enforce current dev version of pyflakes in tox and pre-commit (authored by douardda). · Explain WhyApr 3 2020, 4:09 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNLf3112dbf7cce: Enforce current dev version of pyflakes in tox and pre-commit.