Page MenuHomeSoftware Heritage

Code cleanup to make flake8 happy
ClosedPublic

Authored by douardda on Apr 3 2020, 3:14 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Summary

Depends on D2956.

Diff Detail

Event Timeline

Build has FAILED

Patch application report for D2957 (id=10517)

Could not rebase; Attempt merge onto ca7e9d20c5...

Updating ca7e9d2..8e50e0d
Fast-forward
 .pre-commit-config.yaml                |  15 +++-
 setup.cfg                              |   6 ++
 swh/journal/cli.py                     |   2 +-
 swh/journal/client.py                  |   2 +-
 swh/journal/replay.py                  |  10 +--
 swh/journal/serializers.py             |  10 ++-
 swh/journal/tests/conftest.py          |  18 ++--
 swh/journal/tests/test_cli.py          |   8 +-
 swh/journal/tests/test_kafka_writer.py |  27 +++---
 swh/journal/tests/test_replay.py       |   8 +-
 swh/journal/writer/inmemory.py         |  11 ++-
 swh/journal/writer/kafka.py            | 150 +++++++++++++++++++++------------
 12 files changed, 167 insertions(+), 100 deletions(-)
 create mode 100644 setup.cfg
Changes applied before test
commit 8e50e0d6f6f4d6bc3e308fdef7d2dc854686ffe3
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 15:05:53 2020 +0200

    Code cleanup to make flake8 happy

commit 17d8c0fd81c008416a612fdc50fdef2ec01399a1
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 15:03:32 2020 +0200

    writer: make the writer use swh.model objects instead of (possibly) dicts
    
    And annotate the code as we go.

commit 7e51665eae837164342a5d49bf4cf11d861d16a7
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 14:54:25 2020 +0200

    Update pre-commit config to use a 'local' configuration
    
    This is needed to be able to use flake8 with pyflakes > 2.1.1
    to gain support for @overload on methods.

commit eb6ff79a76a470482624886b50f1b25fd8c03ad6
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 3 13:32:44 2020 +0200

    Add a setup.cfg to make flake8 compatible with blackified files

commit 9c697f6812899d002ee411807fe85611b163a8b7
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Apr 2 15:18:00 2020 +0200

    test: use Multihash to create a valid dict for a Content object

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/9/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/9/console

This revision is now accepted and ready to land.Apr 3 2020, 3:15 PM

closed by f6a398f99a5fa57e590fc4dfaf4fdc880eefba9d

Build is green

Patch application report for D2957 (id=10521)

Rebasing onto f6a398f99a...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-10-D2957.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/10/ for more details.