Page MenuHomeSoftware Heritage

common/identifiers: Add mypy type annotations
ClosedPublic

Authored by anlambert on Apr 2 2020, 5:00 PM.

Details

Summary

Add typing information in swh.web.common.identifiers.

Related to T2342

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Apr 2 2020, 5:02 PM

Update: s/pointed/targeted/ in docstring

Update: Another s/pointed/targeted/ in docstring

Build is green

Patch application report for D2948 (id=10494)

Rebasing onto 8b3e0ce543...

Current branch diff-target is up to date.
Changes applied before test
commit b1b91b6216a06bd8c4f13cc36ad060e9ed8e1938
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 16:58:19 2020 +0200

    common/identifiers: Add mypy type annotations
    
    Related to T2342

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/40/ for more details.

Build has FAILED

Patch application report for D2948 (id=10495)

Rebasing onto 8b3e0ce543...

Current branch diff-target is up to date.
Changes applied before test
commit b49db5042a87d363a91fc5e97417e055a3c692e3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 16:58:19 2020 +0200

    common/identifiers: Add mypy type annotations
    
    Related to T2342

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/41/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/41/console

Build is green

Patch application report for D2948 (id=10496)

Rebasing onto 8b3e0ce543...

Current branch diff-target is up to date.
Changes applied before test
commit 0b54881210a6bc3a043806e96d13728007a77baa
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 16:58:19 2020 +0200

    common/identifiers: Add mypy type annotations
    
    Related to T2342

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/42/ for more details.

Build is green

Patch application report for D2948 (id=10496)

Rebasing onto 8b3e0ce543...

Current branch diff-target is up to date.
Changes applied before test
commit 0b54881210a6bc3a043806e96d13728007a77baa
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 16:58:19 2020 +0200

    common/identifiers: Add mypy type annotations
    
    Related to T2342

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/43/ for more details.