Paths

Table of Contentst

Differential D2936

loader-mercurial: Port to swh-model objects instead of dicts
ClosedPublic
Actions

Authored by anlambert on Mar 31 2020, 9:48 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDHGedc678fffe93: loader: Port to swh-model objects instead of dicts

Summary

Port mercurial loader to swh-model objects instead of dicts as this is now required
by loader API.

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

port-loader-to-swh-model

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11517
Build 17458: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17457: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 31 2020, 9:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 31 2020, 9:48 PM

anlambert planned changes to this revision.Mar 31 2020, 9:49 PM

Build is green

Patch application report for D2936 (id=10435)

Rebasing onto a9028c1115...

Current branch diff-target is up to date.

Changes applied before test

commit 75e28168a3dcf06bc38b35062a1a857add9c05c0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 21:45:21 2020 +0200

    loader: Port to swh-model objects instead of dicts

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B11517: Diff 10435.Mar 31 2020, 9:50 PM

I think that's quite fine as is.
Thanks for making this go green again (it was not required).

(it's missing a requirement update on model at least v0.0.62 iirc but meh ;)

ardumont retitled this revision from [WIP] loader: Port to swh-model objects instead of dicts to [WIP] loader-mercurial: Port to swh-model objects instead of dicts.Apr 1 2020, 10:55 AM

Update: Use more model objects instead of dicts (Revision and Release)

This revision is now accepted and ready to land.Apr 2 2020, 1:54 PM

anlambert retitled this revision from [WIP] loader-mercurial: Port to swh-model objects instead of dicts to loader-mercurial: Port to swh-model objects instead of dicts.Apr 2 2020, 1:55 PM

anlambert edited the summary of this revision. (Show Details)

Build has FAILED

Patch application report for D2936 (id=10481)

Rebasing onto a9028c1115...

Current branch diff-target is up to date.

Changes applied before test

commit 2a1145ca6678df9c92ba639958fc342a690302a5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 21:45:21 2020 +0200

    loader: Port to swh-model objects instead of dicts
    
    This is now a requirement of swh-loader-core API.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/4/console

Harbormaster failed remote builds in B11573: Diff 10481!Apr 2 2020, 1:55 PM

In D2936#71231, @swh-public-ci wrote:
Build has FAILED

Patch application report for D2936 (id=10481)

Rebasing onto a9028c1115...
Current branch diff-target is up to date.
Changes applied before test
commit 2a1145ca6678df9c92ba639958fc342a690302a5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 21:45:21 2020 +0200

    loader: Port to swh-model objects instead of dicts
    
    This is now a requirement of swh-loader-core API.
Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/4/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/4/console

Build will stop failing once D2945 gets landed and a new swh-model tag pushed.

ardumont accepted this revision.Apr 3 2020, 11:50 AM

vlorentz added a subscriber: vlorentz.Apr 3 2020, 1:15 PM

vlorentz added inline comments.

swh/loader/mercurial/tests/common.py
26–35	why this addition?

anlambert added inline comments.Apr 3 2020, 2:00 PM

swh/loader/mercurial/tests/common.py
26–35	I inspired from the git loader test config but indeed this is not needed for those tests. I will update to only use a memory storage.

Update: Sipmlify storage configuration for tests

Build has FAILED

Patch application report for D2936 (id=10509)

Rebasing onto a9028c1115...

Current branch diff-target is up to date.

Changes applied before test

commit edc678fffe93911720d8fb6c4aa7f2f2b58532bd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 21:45:21 2020 +0200

    loader: Port to swh-model objects instead of dicts
    
    This is now a requirement of swh-loader-core API.

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/5/console

Harbormaster failed remote builds in B11600: Diff 10509!Apr 3 2020, 2:01 PM

Build is green

Patch application report for D2936 (id=10509)

Rebasing onto a9028c1115...

Current branch diff-target is up to date.

Changes applied before test

commit edc678fffe93911720d8fb6c4aa7f2f2b58532bd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 21:45:21 2020 +0200

    loader: Port to swh-model objects instead of dicts
    
    This is now a requirement of swh-loader-core API.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/6/ for more details.

Harbormaster completed remote builds in B11600: Diff 10509.Apr 3 2020, 3:08 PM

Closed by commit rDLDHGedc678fffe93: loader: Port to swh-model objects instead of dicts (authored by anlambert). · Explain WhyApr 3 2020, 3:09 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDHGedc678fffe93: loader: Port to swh-model objects instead of dicts.