Page MenuHomeSoftware Heritage
Differential D2895

Shut down the cassandra connection when tearing down the text fixture
ClosedPublic
Actions

Authored by olasd on Mar 26 2020, 8:03 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down
Summary

Maybe this will avoid multiple hundred threads locking one another

Test Plan

let's see what jenkins thinks of this...

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 26 2020, 8:03 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2020, 8:03 PM
olasd edited the test plan for this revision. (Show Details)Mar 26 2020, 8:04 PM
swh-public-ci added a comment.Mar 26 2020, 8:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/console

Harbormaster failed remote builds in B11382: Diff 10301!Mar 26 2020, 8:08 PM
olasd added a comment.Mar 26 2020, 8:11 PM
In D2895#69783, @swh-public-ci wrote:

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/console

But why? Bad Jenkins.

olasd updated this revision to Diff 10302.Mar 26 2020, 8:44 PM

I guess the issue wasn't in swh.journal after all

swh-public-ci added a comment.Mar 26 2020, 8:44 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1100/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1100/console

olasd retitled this revision from Drop multiprocessing manager from the in-memory journal writer to Shut down the cassandra connection when tearing down the text fixture.Mar 26 2020, 8:45 PM
olasd edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Mar 26 2020, 8:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1101/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1101/console

Harbormaster failed remote builds in B11383: Diff 10302!Mar 26 2020, 8:51 PM
swh-public-ci added a comment.Mar 26 2020, 8:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1102/ for more details.

Harbormaster completed remote builds in B11383: Diff 10302.Mar 26 2020, 8:57 PM
swh-public-ci added a comment.Mar 26 2020, 9:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1103/ for more details.

swh-public-ci added a comment.Mar 26 2020, 9:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1104/ for more details.

swh-public-ci added a comment.Mar 26 2020, 9:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1105/ for more details.

swh-public-ci added a comment.Mar 26 2020, 9:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1106/ for more details.

swh-public-ci added a comment.Mar 26 2020, 10:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1107/ for more details.

ardumont accepted this revision.Mar 27 2020, 6:47 AM
ardumont added a subscriber: ardumont.

Thanks a lot!

This revision is now accepted and ready to land.Mar 27 2020, 6:47 AM
Closed by commit rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down (authored by olasd). · Explain WhyMar 27 2020, 9:20 AM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down.

Revision Contents
Changeset List

PathSize
swh/
storage/
tests/
2 lines

Diff 10314

View Options

swh/storage/tests/test_cassandra.py

Loading...
About · Developer information · Legal