Differential D2895

Shut down the cassandra connection when tearing down the text fixture
ClosedPublic
Actions

Authored by olasd on Mar 26 2020, 8:03 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down

Summary

Maybe this will avoid multiple hundred threads locking one another

Test Plan

let's see what jenkins thinks of this...

Diff Detail

Repository

rDSTO Storage manager

Branch

journal-deadlock

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11382
Build 17231: tox-on-jenkins	Jenkins
Build 17230: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 26 2020, 8:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2020, 8:03 PM

olasd edited the test plan for this revision. (Show Details)Mar 26 2020, 8:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/console

Harbormaster failed remote builds in B11382: Diff 10301!Mar 26 2020, 8:08 PM

In D2895#69783, @swh-public-ci wrote:

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1099/console

But why? Bad Jenkins.

I guess the issue wasn't in swh.journal after all

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1100/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1100/console

olasd retitled this revision from Drop multiprocessing manager from the in-memory journal writer to Shut down the cassandra connection when tearing down the text fixture.Mar 26 2020, 8:45 PM

olasd edited the summary of this revision. (Show Details)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1101/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1101/console

Harbormaster failed remote builds in B11383: Diff 10302!Mar 26 2020, 8:51 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1102/ for more details.

Harbormaster completed remote builds in B11383: Diff 10302.Mar 26 2020, 8:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1103/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1104/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1105/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1106/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1107/ for more details.

Thanks a lot!

This revision is now accepted and ready to land.Mar 27 2020, 6:47 AM

Closed by commit rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down (authored by olasd). · Explain WhyMar 27 2020, 9:20 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO570dce27c1b9: Shut down cassandra connection before closing the fixture down.

Revision Contents
Changeset List

Path

Size

12 lines

requirements-swh-journal.txt

2 lines

swh/

journal/

7 lines

458 lines

229 lines

282 lines

direct_writer.py

7 lines

268 lines

1 line

393 lines

32 lines

writer/

27 lines

28 lines

115 lines

Diff 10301

mypy.ini

Loading...

requirements-swh-journal.txt

Loading...

swh/journal/init.py

Loading...

swh/journal/backfill.py

Loading...

swh/journal/cli.py

Loading...

swh/journal/client.py

Loading...

swh/journal/direct_writer.py

Loading...

swh/journal/fixer.py

Loading...

swh/journal/py.typed

Loading...

swh/journal/replay.py

Loading...

swh/journal/serializers.py

Loading...

swh/journal/writer/init.py

Loading...

swh/journal/writer/inmemory.py

Loading...

swh/journal/writer/kafka.py

Loading...