Details

Reviewers

Group Reviewers

Commits

rDWCLI492be567e272: client: Add OpenID Connect bearer token authentication

Summary

By providing a refresh token, obtained with the swh auth login
command to the new authenticate method of the client, all emitted requests
will be authenticated using a bearer token sent in headers.

Example of use:

from swh.web.client import WebAPIClient

REFRESH_TOKEN = '.......'  # Use "swh auth login" command to get it

client = WebAPIClient()
client.authenticate(REFRESH_TOKEN)

# All requests to the Web API will be authenticated
resp = client.get('swh:1:rev:aafb16d69fd30ff58afdd69036a26047f3aebdc6')

Depends on D2861

Related to T1927

Diff Detail

Repository

rDWCLI Web client

Branch

webapiclient-auth

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11297
Build 17082: tox-on-jenkins	Jenkins
Build 17081: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 23 2020, 6:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 23 2020, 6:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tox/13/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tox/13/console

Harbormaster failed remote builds in B11295: Diff 10220!Mar 23 2020, 6:16 PM

In D2869#69155, @swh-public-ci wrote:

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tox/13/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tox/13/console

Looks like I need to update my local version of mypy as I did no get those errors.

swh/web/client/client.py:432: error: Unsupported right operand type for in ("Optional[Dict[str, Any]]")
swh/web/client/client.py:433: error: Value of type "Optional[Dict[str, Any]]" is not indexable
swh/web/client/client.py:435: error: Unsupported target for indexed assignment
swh/web/client/client.py:438: error: Unsupported right operand type for in ("Optional[Dict[str, Any]]")

Update: Fix mypy 0.770 errors

Build is green
See https://jenkins.softwareheritage.org/job/DWCLI/job/tox/14/ for more details.

Harbormaster completed remote builds in B11297: Diff 10222.Mar 23 2020, 6:26 PM

zack accepted this revision.Mar 24 2020, 9:30 AM

This revision is now accepted and ready to land.Mar 24 2020, 9:30 AM

Rebase

anlambert edited the summary of this revision. (Show Details)Mar 24 2020, 12:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWCLI/job/tox/16/ for more details.

Harbormaster completed remote builds in B11307: Diff 10230.Mar 24 2020, 12:04 PM

Update commit message

Build is green
See https://jenkins.softwareheritage.org/job/DWCLI/job/tox/17/ for more details.

Harbormaster completed remote builds in B11308: Diff 10231.Mar 24 2020, 12:07 PM