Don't nest transactions in content_add/skipped_content_add
ClosedPublic
Actions

Authored by olasd on Mar 18 2020, 12:06 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDSTOaaa0e5455c52: Don't nest transactions in content_add/skipped_content_add

Summary

Seems like the cur/db arguments have been missed in one of the various
refactorings, creating separate transactions for these function calls.

Test Plan

tox tests unchanged either

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11185
Build 16887: tox-on-jenkins	Jenkins
Build 16886: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 18 2020, 12:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2020, 12:06 PM

I have a patch somewhere to detect these oversights, but you might not like it...
Let me find it and open a diff

This revision is now accepted and ready to land.Mar 18 2020, 12:28 PM

vlorentz mentioned this in D2846: Detect missing db/cur arguments in 'nested' calls and raise an error..Mar 18 2020, 12:42 PM

ardumont accepted this revision.Mar 18 2020, 12:46 PM

This revision was landed with ongoing or failed builds.Mar 18 2020, 12:52 PM

Closed by commit rDSTOaaa0e5455c52: Don't nest transactions in content_add/skipped_content_add (authored by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOaaa0e5455c52: Don't nest transactions in content_add/skipped_content_add.

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1067/ for more details.

Harbormaster completed remote builds in B11185: Diff 10116.Mar 18 2020, 12:52 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

12 lines

Diff 10116

View Options

Don't nest transactions in content_add/skipped_content_addClosedPublicActions