Page MenuHomeSoftware Heritage

journal: Migrate to latest storage.origin_visit_upsert/add api change
ClosedPublic

Authored by ardumont on Fri, Mar 13, 3:47 PM.

Details

Summary

Related to D2813
Related to D2820

Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Mar 13, 3:47 PM
ardumont retitled this revision from Migrate to latest origin_visit_upsert api change to Migrate to latest storage.origin_visit_upsert api change.Fri, Mar 13, 3:49 PM
ardumont retitled this revision from Migrate to latest storage.origin_visit_upsert api change to journal: Migrate to latest storage.origin_visit_upsert api change.Sat, Mar 14, 11:17 AM
anlambert accepted this revision.Mon, Mar 16, 11:45 AM
anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Mon, Mar 16, 11:45 AM
ardumont updated this revision to Diff 10076.Mon, Mar 16, 3:08 PM

Fix build

ardumont added inline comments.Mon, Mar 16, 3:10 PM
swh/journal/tests/test_write_replay.py
58

I'd be great to be able to use the objects() generator here.
But we can't as it's generated without consistency with the other types yet (e.g. Origin and OriginVisit for one)

So that makes the test fail.

ardumont retitled this revision from journal: Migrate to latest storage.origin_visit_upsert api change to journal: Migrate to latest storage.origin_visit_upsert/add api change.Mon, Mar 16, 3:14 PM
ardumont edited the summary of this revision. (Show Details)

I don't understand the issue. What do you mean by "without consistency"?

And why is the origin visit date missing at all?

I don't understand the issue. What do you mean by "without consistency"?

It means origin_visit's origin reference generated is not necessarily connected with the origin generated otherwise.

And why is the origin visit date missing at all?

no idea.

I don't understand the issue. What do you mean by "without consistency"?

It means origin_visit's origin reference generated is not necessarily connected with the origin generated otherwise.

You could evolve it

I don't understand the issue. What do you mean by "without consistency"?

It means origin_visit's origin reference generated is not necessarily connected with the origin generated otherwise.

You could evolve it

sure.

That's not an issue for landing this diff.
I made the comment so that we see that future improvment in our hypothesis strategies in the model module.

vlorentz accepted this revision.Mon, Mar 16, 3:19 PM
This revision was automatically updated to reflect the committed changes.