Details
- Reviewers
anlambert vlorentz - Group Reviewers
Reviewers - Commits
- rDJNLd3d5b7977186: Migrate to latest origin_visit_upsert/add api changes
tox
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/395/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/395/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/396/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/396/console
| swh/journal/tests/test_write_replay.py | ||
|---|---|---|
| 58 | I'd be great to be able to use the objects() generator here. So that makes the test fail. | |
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/397/ for more details.
I don't understand the issue. What do you mean by "without consistency"?
And why is the origin visit date missing at all?
I don't understand the issue. What do you mean by "without consistency"?
It means origin_visit's origin reference generated is not necessarily connected with the origin generated otherwise.
And why is the origin visit date missing at all?
no idea.
I don't understand the issue. What do you mean by "without consistency"?
It means origin_visit's origin reference generated is not necessarily connected with the origin generated otherwise.
You could evolve it
sure.
That's not an issue for landing this diff.
I made the comment so that we see that future improvment in our hypothesis strategies in the model module.