test/model: do not test direct instanciation of model objects
ClosedPublic
Actions

Authored by douardda on Mar 11 2020, 5:55 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD56ae59c5ddbd: test/model: do not test direct instanciation of model objects

Summary

this does not work in the general case since there is no (recursive)
convertion of objects used as model object initialization.

We can only check when using the from_dict() factory.

Depends on D2816.

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 11080
Build 16700: tox-on-jenkins	Jenkins
Build 16699: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 11 2020, 5:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 11 2020, 5:55 PM

douardda added a child revision: D2818: tests/identifiers: fix 'target', 'directory' and 'parents' object types.Mar 11 2020, 5:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/212/ for more details.

Harbormaster completed remote builds in B11080: Diff 10008.Mar 11 2020, 5:56 PM

Request changes for the sake of the discussion below.

We can only check when using the from_dict() factory.

Oh, right, nice catch.

Question is, don't we want this to work recursively from the constructor?

This revision now requires changes to proceed.Mar 11 2020, 7:56 PM

Question is, don't we want this to work recursively from the constructor?

oh well, we can have that question later, i think.

This revision is now accepted and ready to land.Mar 12 2020, 2:15 PM

Closed by commit rDMOD56ae59c5ddbd: test/model: do not test direct instanciation of model objects (authored by douardda). · Explain WhyMar 12 2020, 2:53 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMOD56ae59c5ddbd: test/model: do not test direct instanciation of model objects.

Revision Contents
Changeset List

Path

Size

swh/

model/

tests/

test_model.py

25 lines

Diff 10008

View Options

swh/model/tests/test_model.py

test/model: do not test direct instanciation of model objectsClosedPublicActions