Differential D2804

Clean up the signature of test_cli's invoke method
ClosedPublic
Actions

Authored by olasd on Mar 10 2020, 4:58 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDJNL9fe8f263a56b: Clean up the signature of test_cli's invoke method

Summary

Drop catch_exception as it's not used anywhere (and we always assert on result.return_code)
Make the argument list a starargs instead of having to make a list

Depends on D2802

Test Plan

tox tests updated

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 10 2020, 4:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2020, 4:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/371/ for more details.

Harbormaster completed remote builds in B11033: Diff 9961.Mar 10 2020, 5:02 PM

ardumont accepted this revision.Mar 10 2020, 5:25 PM

This revision is now accepted and ready to land.Mar 10 2020, 5:25 PM

olasd added a child revision: D2805: Replace deprecated options with a config file override in cli tests.Mar 10 2020, 5:57 PM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/379/ for more details.

Harbormaster completed remote builds in B11045: Diff 9973.Mar 10 2020, 7:52 PM

Closed by commit rDJNL9fe8f263a56b: Clean up the signature of test_cli's invoke method (authored by olasd). · Explain WhyMar 10 2020, 7:56 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNL9fe8f263a56b: Clean up the signature of test_cli's invoke method.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

46 lines

Diff 9979

swh/journal/tests/test_cli.py

Loading...