Paths

Table of Contentst

Differential D2794

exceptions: custom error response
ClosedPublic
Actions

Authored by DanSeraf on Mar 10 2020, 12:11 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDTSCNcb5faf6e866a: exceptions: APIError response
rDTSCN1857499820d0: let live_server start directly

Summary

Print an error message based on http response (T2300)

Diff Detail

Repository

rDTSCN Code scanner

Branch

response-api-error

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11013
Build 16581: tox-on-jenkins	Jenkins
Build 16580: arc lint + arc unit

Event Timeline

DanSeraf created this revision.Mar 10 2020, 12:11 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2020, 12:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/10/ for more details.

Harbormaster completed remote builds in B11013: Diff 9942.Mar 10 2020, 12:12 PM

Now that swh-scanner has tests, it would be nice if every new feature and bugfix added (or changed) one or more tests.

swh/scanner/exceptions.py
13–15	nitpick: inconsistent casing, and s/request/requests/
20	You can probably use `resp.reason` instead of `status_code_msg[resp.status]`

vlorentz requested changes to this revision.Mar 10 2020, 12:18 PM

This revision now requires changes to proceed.Mar 10 2020, 12:18 PM

In D2794#66864, @vlorentz wrote:

Now that swh-scanner has tests, it would be nice if every new feature and bugfix added (or changed) one or more tests.

Yes, i'll write test also on this one

assert APIError raises when the payload is too large
live_server override, only one per session

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tox/11/console

Harbormaster failed remote builds in B11023: Diff 9952!Mar 10 2020, 3:11 PM

flake8

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/12/ for more details.

Harbormaster completed remote builds in B11025: Diff 9954.Mar 10 2020, 3:16 PM

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/13/ for more details.

Harbormaster completed remote builds in B11037: Diff 9965.Mar 10 2020, 6:03 PM

vlorentz accepted this revision.Mar 10 2020, 7:50 PM

vlorentz added inline comments.

swh/scanner/tests/conftest.py
63–66 ↗	(On Diff #9965)	slightly confusing, but ok. Maybe a comment?
swh/scanner/tests/test_scanner.py
45 ↗	(On Diff #9965)	You can also use the `match` argument in APIError to check the reason is there, but that's not very important

This revision is now accepted and ready to land.Mar 10 2020, 7:50 PM

DanSeraf added inline comments.Mar 11 2020, 9:29 AM

swh/scanner/tests/conftest.py
63–66 ↗	(On Diff #9965)	there is no need of overriding the live_server so i'll remove the no-start-live-server option in pytest.ini

removed --no-start-live-server option in pytest.ini

Build is green
See https://jenkins.softwareheritage.org/job/DTSCN/job/tox/14/ for more details.

Harbormaster completed remote builds in B11055: Diff 9983.Mar 11 2020, 9:35 AM

Closed by commit rDTSCN1857499820d0: let live_server start directly (authored by DanSeraf). · Explain WhyMar 11 2020, 9:51 AM

This revision was automatically updated to reflect the committed changes.

DanSeraf added a commit: rDTSCN1857499820d0: let live_server start directly.

DanSeraf added a commit: rDTSCNcb5faf6e866a: exceptions: APIError response.

Revision Contents
Changeset List

Path

Size

swh/

scanner/

14 lines

6 lines

Diff 9942

swh/scanner/exceptions.py

Loading...

swh/scanner/scanner.py

Loading...