Page MenuHomeSoftware Heritage
Differential D2773

Guarantee the order of results for revision_get and release_get
ClosedPublic
Actions

Authored by olasd on Mar 5 2020, 3:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDSTO88fe9428678f: Guarantee the order of results for revision_get and release_get
Summary

It's a bit silly, but we depend on it for some tests.

Test Plan

new tox tests added

Diff Detail

Repository
rDSTO Storage manager
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11002
Build 16563: tox-on-jenkinsJenkins
Build 16562: arc lint + arc unit

Event Timeline

olasd created this revision.Mar 5 2020, 3:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 5 2020, 3:55 PM
olasd mentioned this in D2771: Make release_add support adding the same object twice in the same call.Mar 5 2020, 3:55 PM
swh-public-ci added a comment.Mar 5 2020, 4:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1020/ for more details.

Harbormaster completed remote builds in B10936: Diff 9868.Mar 5 2020, 4:01 PM
olasd added a child revision: D2771: Make release_add support adding the same object twice in the same call.Mar 5 2020, 4:10 PM
vlorentz requested changes to this revision.Mar 6 2020, 1:16 AM
vlorentz added a subscriber: vlorentz.

wtf, did it all work thanks to an UB so far? And why aren't all the _missing completely broken then?

And we also want this for the other object types for consistency

This revision now requires changes to proceed.Mar 6 2020, 1:16 AM
olasd requested review of this revision.EditedMar 6 2020, 2:51 PM
In D2773#66328, @vlorentz wrote:

wtf, did it all work thanks to an UB so far? And why aren't all the _missing completely broken then?

Because the _missing tests operate on sets (i.e. the caller doesn't care about the order, I think).

And we also want this for the other object types for consistency

Which other object types have a _get method that takes multiple objects?

olasd added a comment.Mar 9 2020, 12:14 PM
In D2773#66477, @olasd wrote:

And we also want this for the other object types for consistency

Which other object types have a _get method that takes multiple objects?

Ping @vlorentz?

vlorentz accepted this revision.Mar 9 2020, 12:29 PM

None, indeed. Sorry

swh/storage/tests/test_storage.py
958–959

You shouldn't need from_dict/to_dict

1220–1221

same

This revision is now accepted and ready to land.Mar 9 2020, 12:29 PM
olasd updated this revision to Diff 9930.Mar 9 2020, 4:52 PM

Apply comments

olasd updated this revision to Diff 9931.Mar 9 2020, 4:53 PM

Rebase

This revision was landed with ongoing or failed builds.Mar 9 2020, 4:59 PM
Closed by commit rDSTO88fe9428678f: Guarantee the order of results for revision_get and release_get (authored by olasd). · Explain Why
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSTO88fe9428678f: Guarantee the order of results for revision_get and release_get.
Harbormaster failed remote builds in B11001: Diff 9930!Mar 9 2020, 6:44 PM
swh-public-ci added a comment.Mar 9 2020, 6:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1035/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1035/console

Harbormaster failed remote builds in B11002: Diff 9931!Mar 9 2020, 6:44 PM
swh-public-ci added a comment.Mar 9 2020, 6:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1036/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1036/console

Revision Contents
Changeset List

PathSize
swh/
storage/
10 lines
tests/
42 lines

Diff 9931

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal