loaders: Remove the validation proxy setup
ClosedPublic
Actions

Authored by ardumont on Mar 2 2020, 1:49 PM.

Details

Reviewers

vlorentz
olasd

Group Reviewers

Reviewers

Commits

rSPSITE8ff80634fe2b: loaders: Remove the validation proxy

Summary

The loaders are now sending the full swh.model.model objects.

Another way would be:

as a first iterative step, to keep that setup (abandonning this diff)
make the validation storage actually allows swh.model.model objects as input (no-op)
then as another optional step (we'd be isofunctional for now without it), make the actual integrity checks (hashing the manifest to its id(s) and compare)

What do you think?

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 2 2020, 1:49 PM

Harbormaster completed remote builds in B10825: Diff 9763.Mar 2 2020, 1:49 PM

ardumont retitled this revision from loaders: Remove the validation proxy to loaders: Remove the validation proxy setup.Mar 2 2020, 1:54 PM

ardumont edited the summary of this revision. (Show Details)Mar 2 2020, 2:08 PM

Considering the amount of breaking changes between swh.loader.*, swh.model, swh.core and swh.storage, I think we're due for a "stop the world" upgrade anyway. At this point I don't think there's much point tweaking the validate proxy anymore.

ardumont edited the summary of this revision. (Show Details)Mar 2 2020, 2:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2020, 3:22 PM

Closed by commit rSPSITE8ff80634fe2b: loaders: Remove the validation proxy (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITE8ff80634fe2b: loaders: Remove the validation proxy.

douardda mentioned this in D7232: Skip a maven encoding validation test broken by expat.Feb 24 2022, 10:41 AM