Page MenuHomeSoftware Heritage
Differential D2730

Use swh-model objects in base VCS loader.
ClosedPublic
Actions

Authored by vlorentz on Feb 28 2020, 1:41 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDBASE43728c596498: Use swh-model objects in base VCS loader.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 28 2020, 1:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 28 2020, 1:41 PM
vlorentz mentioned this in D2731: Use swh-model objects instead of dicts..Feb 28 2020, 1:42 PM
swh-public-ci added a comment.Feb 28 2020, 1:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/338/ for more details.

Harbormaster completed remote builds in B10802: Diff 9735.Feb 28 2020, 1:47 PM
ardumont added a subscriber: ardumont.Feb 28 2020, 1:47 PM
ardumont added inline comments.
swh/loader/core/loader.py
390

Can't we make this return a Tuple[List[Content], List[SkippedContent]] instead?

ardumont accepted this revision.Feb 28 2020, 1:48 PM
This revision is now accepted and ready to land.Feb 28 2020, 1:48 PM
vlorentz added inline comments.Feb 28 2020, 3:00 PM
swh/loader/core/loader.py
390

I considered it, and I don't think either way is better than the other.

ardumont added inline comments.Feb 28 2020, 3:00 PM
swh/loader/core/loader.py
390

Agreed.
Let's keep the code as is then ;)

Closed by commit rDLDBASE43728c596498: Use swh-model objects in base VCS loader. (authored by vlorentz). · Explain WhyFeb 28 2020, 5:04 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDLDBASE43728c596498: Use swh-model objects in base VCS loader..

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
49 lines
tests/
16 lines
tests/
3 lines

Diff 9753

View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
View Options

swh/loader/tests/conftest.py

Loading...
About · Developer information · Legal