Sort from_disk.Directory entries.
ClosedPublic
Actions

Authored by vlorentz on Feb 20 2020, 4:47 PM.

Details

Reviewers

anlambert
olasd

Group Reviewers

Reviewers

Summary

It should be cheap enough to do it, and it makes tests easier.

Depends on D2704.

Diff Detail

Repository

rDMOD Data model

Branch

sort-entries

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10713
Build 16071: tox-on-jenkins	Jenkins
Build 16070: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 20 2020, 4:47 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 20 2020, 4:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/178/ for more details.

Harbormaster completed remote builds in B10713: Diff 9649.Feb 20 2020, 4:48 PM

vlorentz added a child revision: D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..Feb 20 2020, 4:51 PM

anlambert accepted this revision.Feb 20 2020, 5:19 PM

This revision is now accepted and ready to land.Feb 20 2020, 5:19 PM

I think it makes sense to sort the entries, but I think we should really do it the same way the directory identifiers want the entries sorted;

This means using linus's very nice "directories have a / appended to their names" sort instead of a simple sort.

vlorentz planned changes to this revision.Feb 20 2020, 5:46 PM

use git order

This revision is now accepted and ready to land.Feb 21 2020, 12:03 PM

vlorentz edited the summary of this revision. (Show Details)Feb 21 2020, 12:03 PM

vlorentz added a parent revision: D2704: Add test for git directory entries order..

vlorentz removed a parent revision: D2701: Add support for skipping large contents in from_disk..

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/182/ for more details.

Harbormaster completed remote builds in B10717: Diff 9653.Feb 21 2020, 12:04 PM

olasd accepted this revision.Feb 21 2020, 1:21 PM

4c070f98ca09255a54fb3fc9efbcf9d6e099ac96

vlorentz removed a child revision: D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..Feb 21 2020, 4:35 PM

vlorentz added a child revision: D2703: Add to_model() method to from_disk.{Content,Directory}, to convert to canonical model objects..Feb 24 2020, 4:06 PM

Revision Contents
Changeset List

Path

Size

swh/

model/

from_disk.py

3 lines

tests/

test_from_disk.py

2 lines

Diff 9649

View Options

swh/model/from_disk.py