Differential D2688

Handle ObjNotFoundError and Error as client errors instead of server errors.
ClosedPublic
Actions

Authored by vlorentz on Feb 18 2020, 1:39 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDOBJSb23bf3fa4c11: Handle ObjNotFoundError and Error as client errors instead of server errors.

Summary

Meaning that:

server should raise 400 on these errors instead of 500
client should catch them and re-raise them.

Test Plan

Tests will fail because this diff depends on D2687.

Diff Detail

Repository

rDOBJS Object storage

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10665
Build 15985: tox-on-jenkins	Jenkins
Build 15984: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 18 2020, 1:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2020, 1:39 PM

vlorentz mentioned this in D2684: objstorage_testsing: Fix some RPC tests after recent changes in swh-core.Feb 18 2020, 1:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/105/ for more details.

Harbormaster completed remote builds in B10658: Diff 9597.Feb 18 2020, 1:40 PM

anlambert accepted this revision.Feb 18 2020, 1:51 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/objstorage/api/client.py
1	2020
swh/objstorage/api/server.py
1	2020

This revision is now accepted and ready to land.Feb 18 2020, 1:51 PM

update copyrights

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/106/ for more details.

Harbormaster completed remote builds in B10665: Diff 9604.Feb 18 2020, 2:05 PM

Closed by commit rDOBJSb23bf3fa4c11: Handle ObjNotFoundError and Error as client errors instead of server errors. (authored by vlorentz). · Explain WhyFeb 18 2020, 2:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDOBJSb23bf3fa4c11: Handle ObjNotFoundError and Error as client errors instead of server errors..

Revision Contents
Changeset List

Path

Size

swh/

objstorage/

api/

client.py

15 lines

server.py

26 lines

Diff 9604

View Options

swh/objstorage/api/client.py