Page MenuHomeSoftware Heritage
Differential D2684

objstorage_testsing: Fix some RPC tests after recent changes in swh-core
AbandonedPublic
Actions

Authored by anlambert on Feb 17 2020, 5:16 PM.

Details

Reviewers
vlorentz
olasd
Group Reviewers
Reviewers
Summary

Remote exception handling has changed since rDCORE08289ce5c33e507ec3ce80cade86f688b4107f3f

Diff Detail

Repository
rDOBJS Object storage
Branch
fix-rpc-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10639
Build 15940: tox-on-jenkinsJenkins
Build 15939: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 17 2020, 5:16 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 17 2020, 5:16 PM
swh-public-ci added a comment.Feb 17 2020, 5:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/104/ for more details.

Harbormaster completed remote builds in B10639: Diff 9580.Feb 17 2020, 5:18 PM
anlambert added a reviewer: vlorentz.Feb 17 2020, 5:45 PM
olasd requested changes to this revision.Feb 18 2020, 11:30 AM
olasd added a subscriber: olasd.

The objstorage api client should re-raise the exception rather than clients having to handle two exceptions: lots of clients depend on the ObjNotFound behavior at this point.

This revision now requires changes to proceed.Feb 18 2020, 11:30 AM
anlambert abandoned this revision.Feb 18 2020, 11:44 AM

Abandoning this and let @vlorentz properly fixing the issue

vlorentz added a comment.Feb 18 2020, 1:39 PM
In D2684#64107, @anlambert wrote:

Abandoning this and let @vlorentz properly fixing the issue

D2687 and D2688

Revision Contents
Changeset List

PathSize
swh/
objstorage/
tests/
11 lines

Diff 9580

View Options

swh/objstorage/tests/objstorage_testing.py

Loading...
About · Developer information · Legal