Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDJNLeea69820792f: JournalClient: split main loop in three functions
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/329/ for more details.
Comment Actions
You should give a hint in your commit message on why you do this refactoring.
For example, the introduction of the deserialize_message method seems overkill (oneliner that do almost nothing more than calling another method) if we do not know why this method is extracted.
| swh/journal/client.py | ||
|---|---|---|
| 174–191 | no need for the nb_processed var here | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/332/ for more details.