Page MenuHomeSoftware Heritage

JournalClient: split main loop in three functions
Needs RevisionPublic

Authored by seirl on Tue, Feb 11, 5:26 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10549
Build 15738: tox-on-jenkinsJenkins
Build 15737: arc lint + arc unit

Event Timeline

seirl created this revision.Tue, Feb 11, 5:26 PM
douardda requested changes to this revision.Wed, Feb 12, 9:55 AM
douardda added a subscriber: douardda.

You should give a hint in your commit message on why you do this refactoring.

For example, the introduction of the deserialize_message method seems overkill (oneliner that do almost nothing more than calling another method) if we do not know why this method is extracted.

swh/journal/client.py
168–169

no need for the nb_processed var here

This revision now requires changes to proceed.Wed, Feb 12, 9:55 AM