Page MenuHomeSoftware Heritage

JournalClient: split main loop in three functions
ClosedPublic

Authored by seirl on Feb 11 2020, 5:26 PM.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda added a subscriber: douardda.

You should give a hint in your commit message on why you do this refactoring.

For example, the introduction of the deserialize_message method seems overkill (oneliner that do almost nothing more than calling another method) if we do not know why this method is extracted.

swh/journal/client.py
174–191

no need for the nb_processed var here

This revision now requires changes to proceed.Feb 12 2020, 9:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2020, 12:28 PM
This revision was automatically updated to reflect the committed changes.