Differential D2631

loader.core/package: Call storage's (skipped_)content_add endpoints
ClosedPublic
Actions

Authored by ardumont on Feb 6 2020, 3:15 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDLDBASE38c09a87ab04: loader.core.converters: Prefer the with open pattern to read file
rDLDBASE588b06d8adf4: tests: Use new get_storage signature
rDLDBASEfa65c2afe991: test_converters: Add coverage on prepare_contents method
rDLDBASE883858517030: test_converters: Migrate to pytest
rDLDBASEda15a25eaf24: loader.core/package: Call storage's (skipped_)content_add endpoints

Summary

Migrate to new storage endpoints use.
All package loaders will benefit from it directly.

Impacts identified (diff on their way):

loader-svn
loader-mercurial

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 6 2020, 3:15 PM

vlorentz added inline comments.Feb 6 2020, 3:19 PM

swh/loader/core/converters.py
18–22	I don't find the name and docstring explicit enough, but I don't have any better idea for the name :/
18–37	why not switch to passing model objects instead of converting them back to dicts?

ardumont added inline comments.Feb 6 2020, 3:20 PM

swh/loader/core/converters.py
18	contents_for_storage, prepare_contents_for_storage?
18–37	because right now, it's not supported. so might as well convert here to avoid impacts in other callers.

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/323/ for more details.

Harbormaster completed remote builds in B10471: Diff 9412.Feb 6 2020, 3:21 PM

vlorentz accepted this revision.Feb 6 2020, 3:23 PM

This revision is now accepted and ready to land.Feb 6 2020, 3:23 PM

Closed by commit rDLDBASEda15a25eaf24: loader.core/package: Call storage's (skipped_)content_add endpoints (authored by ardumont). · Explain WhyFeb 6 2020, 3:28 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEda15a25eaf24: loader.core/package: Call storage's (skipped_)content_add endpoints.

ardumont added a commit: rDLDBASE883858517030: test_converters: Migrate to pytest.

ardumont added a commit: rDLDBASEfa65c2afe991: test_converters: Add coverage on prepare_contents method.

ardumont added a commit: rDLDBASE38c09a87ab04: loader.core.converters: Prefer the with open pattern to read file.

ardumont added a commit: rDLDBASE588b06d8adf4: tests: Use new get_storage signature.

Revision Contents
Changeset List

Path

Size

requirements-swh.txt

2 lines

swh/

loader/

core/

52 lines

13 lines

tests/

test_converters.py

27 lines

package/

17 lines

Diff 9413

requirements-swh.txt

Loading...

swh/loader/core/converters.py

Loading...

swh/loader/core/loader.py

Loading...

swh/loader/core/tests/test_converters.py

Loading...

swh/loader/package/loader.py

Loading...