Page MenuHomeSoftware Heritage
Differential D2607

model: Update revision date types to be optional
ClosedPublic
Actions

Authored by ardumont on Jan 30 2020, 3:40 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMOD4b779e1e4874: test_model: Simplify and align model checks
rDMODb54adf79da6b: model: Update revision date types to be optional
Summary

Related to P589

Test Plan

tox

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10386
Build 15454: tox-on-jenkinsJenkins
Build 15453: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 30 2020, 3:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 30 2020, 3:40 PM
swh-public-ci added a comment.Jan 30 2020, 3:41 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/163/ for more details.

Harbormaster completed remote builds in B10383: Diff 9320.Jan 30 2020, 3:41 PM
vlorentz requested changes to this revision.Jan 30 2020, 4:07 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/tests/test_model.py
110

should compare its value

This revision now requires changes to proceed.Jan 30 2020, 4:07 PM
ardumont updated this revision to Diff 9321.Jan 30 2020, 4:31 PM

Improve checks

swh-public-ci added a comment.Jan 30 2020, 4:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/164/ for more details.

Harbormaster completed remote builds in B10384: Diff 9321.Jan 30 2020, 4:32 PM
vlorentz accepted this revision.Jan 30 2020, 4:35 PM
vlorentz added inline comments.
swh/model/tests/test_model.py
110

You can remove this assertion now, it's redundant because of the last one

This revision is now accepted and ready to land.Jan 30 2020, 4:35 PM
ardumont updated this revision to Diff 9322.Jan 30 2020, 4:38 PM

Remove spurious check

swh-public-ci added a comment.Jan 30 2020, 4:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/165/ for more details.

Harbormaster completed remote builds in B10385: Diff 9322.Jan 30 2020, 4:39 PM
ardumont added inline comments.Jan 30 2020, 4:41 PM
swh/model/tests/test_model.py
110

yes but i somehow kept it to be consistent with the other checks...

ardumont updated this revision to Diff 9323.Jan 30 2020, 4:42 PM
  • test_model: Simplify and align model checks
swh-public-ci added a comment.Jan 30 2020, 4:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/166/ for more details.

Harbormaster completed remote builds in B10386: Diff 9323.Jan 30 2020, 4:43 PM
ardumont updated this revision to Diff 9324.Jan 30 2020, 4:44 PM

Remove spurious check and align variable name

swh-public-ci added a comment.Jan 30 2020, 4:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/167/ for more details.

Harbormaster completed remote builds in B10387: Diff 9324.Jan 30 2020, 4:45 PM
Closed by commit rDMODb54adf79da6b: model: Update revision date types to be optional (authored by ardumont). · Explain WhyJan 30 2020, 4:46 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDMODb54adf79da6b: model: Update revision date types to be optional.
ardumont added a commit: rDMOD4b779e1e4874: test_model: Simplify and align model checks.

Revision Contents
Changeset List

PathSize
swh/
model/
18 lines
tests/
55 lines

Diff 9323

View Options

swh/model/model.py

Loading...
View Options

swh/model/tests/test_model.py

Loading...
About · Developer information · Legal