Page MenuHomeSoftware Heritage

model: Update revision date types to be optional
ClosedPublic

Authored by ardumont on Jan 30 2020, 3:40 PM.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/tests/test_model.py
101

should compare its value

This revision now requires changes to proceed.Jan 30 2020, 4:07 PM
vlorentz added inline comments.
swh/model/tests/test_model.py
101

You can remove this assertion now, it's redundant because of the last one

This revision is now accepted and ready to land.Jan 30 2020, 4:35 PM
swh/model/tests/test_model.py
101

yes but i somehow kept it to be consistent with the other checks...

  • test_model: Simplify and align model checks

Remove spurious check and align variable name