Differential D2589

Add return type to get_storage.
AbandonedPublic
Actions

Authored by vlorentz on Jan 24 2020, 6:12 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Summary

Depends on D2587, D2588.

Diff Detail

Repository

rDSTO Storage manager

Branch

get_storage-return-type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10348
Build 15383: tox-on-jenkins	Jenkins
Build 15382: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 24 2020, 6:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2020, 6:12 PM

Harbormaster failed remote builds in B10287: Diff 9226!Jan 24 2020, 6:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/900/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/900/console

ardumont requested changes to this revision.Jan 28 2020, 2:13 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/storage/__init__.py
72	mmmph, ugly. prefer the old version. Also can't we raise a more explicit message as i remember we do in other part of the stack. raise ValueError('Unsupported storage. Choices are...') or something.

This revision now requires changes to proceed.Jan 28 2020, 2:13 PM

vlorentz added inline comments.Jan 28 2020, 2:42 PM

swh/storage/__init__.py
72	prefer the old version. mypy says doesn't like the old version. Also can't we raise a more explicit message as i remember we do in other part of the stack. sure

rebase

woops, pushed to the wrong diff again (yes, I updated the counter on the whiteboard)

rebase

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/916/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/916/console

Harbormaster failed remote builds in B10332: Diff 9274!Jan 29 2020, 12:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/918/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/918/console

Harbormaster failed remote builds in B10334: Diff 9276!Jan 29 2020, 12:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/919/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/919/console

Harbormaster failed remote builds in B10335: Diff 9277!Jan 29 2020, 12:31 PM

rebase

Harbormaster failed remote builds in B10348: Diff 9288!Jan 29 2020, 2:34 PM

better error message

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/926/ for more details.

ardumont accepted this revision.Jan 29 2020, 2:52 PM

This revision is now accepted and ready to land.Jan 29 2020, 2:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/927/ for more details.

Harbormaster completed remote builds in B10349: Diff 9289.Jan 29 2020, 2:54 PM

Actually, that's a bad idea. It makes mypy refuse backend classes with missing endpoints (even deprecated ones)

Revision Contents
Changeset List

Path

Size

requirements.txt

1 line

swh/

storage/

26 lines

4 lines

Diff 9288

requirements.txt

Loading...

swh/storage/init.py

Loading...

swh/storage/interface.py

Loading...