Page MenuHomeSoftware Heritage
Differential D2585

Add tests for db_transaction and db_transaction_generator.
ClosedPublic
Actions

Authored by vlorentz on Jan 24 2020, 5:39 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCORE0d367617a179: Add tests for db_transaction and db_transaction_generator.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 24 2020, 5:39 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2020, 5:39 PM
vlorentz updated this revision to Diff 9220.Jan 24 2020, 5:40 PM

remove useless fixture

swh-public-ci added a comment.Jan 24 2020, 5:40 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/391/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/391/console

Harbormaster failed remote builds in B10280: Diff 9219!Jan 24 2020, 5:40 PM
swh-public-ci added a comment.Jan 24 2020, 5:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/392/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/392/console

Harbormaster failed remote builds in B10281: Diff 9220!Jan 24 2020, 5:42 PM
vlorentz added a child revision: D2586: Make db_transaction* remove db/cur from the signature..Jan 24 2020, 5:45 PM
vlorentz updated this revision to Diff 9223.Jan 24 2020, 5:54 PM

add missing dep

swh-public-ci added a comment.Jan 24 2020, 5:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/394/ for more details.

Harbormaster completed remote builds in B10284: Diff 9223.Jan 24 2020, 5:55 PM
ardumont added a subscriber: ardumont.Jan 27 2020, 11:12 AM

looks like D2585 and D2586 are entangled together.

vlorentz updated this revision to Diff 9232.Jan 27 2020, 1:28 PM

remove commit

swh-public-ci added a comment.Jan 27 2020, 1:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/395/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/395/console

Harbormaster failed remote builds in B10293: Diff 9232!Jan 27 2020, 1:30 PM
vlorentz updated this revision to Diff 9233.Jan 27 2020, 1:35 PM

add missing dep

swh-public-ci added a comment.Jan 27 2020, 1:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/396/ for more details.

Harbormaster completed remote builds in B10294: Diff 9233.Jan 27 2020, 1:36 PM
ardumont accepted this revision.Jan 28 2020, 2:10 PM
ardumont added inline comments.
swh/core/db/tests/test_db.py
190

not used, most probably wrong commit.

This revision is now accepted and ready to land.Jan 28 2020, 2:10 PM
vlorentz added inline comments.Jan 28 2020, 2:41 PM
swh/core/db/tests/test_db.py
190

it is used. The test checks it raises a ValueError.

ardumont added inline comments.Jan 28 2020, 2:42 PM
swh/core/db/tests/test_db.py
190

heh, missed it ;)

Closed by commit rDCORE0d367617a179: Add tests for db_transaction and db_transaction_generator. (authored by vlorentz). · Explain WhyJan 29 2020, 12:20 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE0d367617a179: Add tests for db_transaction and db_transaction_generator..

Revision Contents
Changeset List

PathSize
1 line
swh/
core/
db/
tests/
81 lines

Diff 9278

View Options

requirements-test.txt

Loading...
View Options

swh/core/db/tests/test_db.py

Loading...
About · Developer information · Legal