Pass ObjNotFoundErr as a 404 error rather than 500
ClosedPublic
Actions

Authored by olasd on Oct 20 2017, 4:07 PM.

Details

Reviewers

Group Reviewers

Commits

rDOBJS80788ffe6a43: Pass ObjNotFoundErr as a 404 error rather than 500
rDOBJSd726ab21c131: objstorage_testing: ensure consistency in ObjNotFoundErrors

Summary

objstorage_testing: ensure consistency in ObjNotFoundErrors
This should reduce logging when using deployed gunicorn

Test Plan

tests still pass

Diff Detail

Repository

rDOBJS Object storage

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1055
Build 1390: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 20 2017, 4:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 20 2017, 4:07 PM

Harbormaster completed remote builds in B1055: Diff 859.Oct 20 2017, 4:07 PM

#swh-devel discussion:

16:08:01 <+olasd> seirl: https://forge.softwareheritage.org/D257
16:10:31 <+seirl> i don't like the fact that the client API can't differenciate between None and not found
16:10:40 <+olasd> me neither
16:10:44 <+seirl> but it's not because of this diff, so, yeah...
16:10:49 <+olasd> exactly
16:11:05 <+seirl> maybe just add a # TODO before pushing?
16:11:17 <+olasd> well it's not a todo for this repo
16:11:28 <+olasd> our RPC stuff is bad and I should feel bad

Closed by commit rDOBJSd726ab21c131: objstorage_testing: ensure consistency in ObjNotFoundErrors (authored by olasd). · Explain WhyOct 31 2017, 2:38 PM

This revision was automatically updated to reflect the committed changes.