Page MenuHomeSoftware Heritage

cran.lister: Version uid so we can list new package versions
ClosedPublic

Authored by ardumont on Jan 15 2020, 10:53 AM.

Details

Summary

Prior to this commit, the uid was the plain package's name.
Internal lister's mechanism would result in preventing to see new versions.
So it's important this uid is unique per version.

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10144
Build 15047: tox-on-jenkinsJenkins
Build 15046: arc lint + arc unit

Event Timeline

Doesn't this require a migration of existing data?

Doesn't this require a migration of existing data?

Yes and no.

Yes, but that's something not seen in the lister's code...
I do not know why we are inconsistent regarding model migration in that repository.

And no because, in any case, i will truncate the existing rows.
I will start the cran listing from scratch when this will be deployed ;)

ardumont edited the summary of this revision. (Show Details)

Reuse version variable

This revision is now accepted and ready to land.Jan 16 2020, 1:38 PM