Page MenuHomeSoftware Heritage

cran.lister: Version uid so we can list new package versions
ClosedPublic

Authored by ardumont on Jan 15 2020, 10:53 AM.

Details

Summary

Prior to this commit, the uid was the plain package's name.
Internal lister's mechanism would result in preventing to see new versions.
So it's important this uid is unique per version.

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 15 2020, 10:53 AM
ardumont updated this revision to Diff 9008.Jan 15 2020, 1:50 PM

Detach dependency from D2524

ardumont updated this revision to Diff 9011.Jan 15 2020, 1:56 PM

Add back checks on record's uid format

ardumont edited the summary of this revision. (Show Details)Jan 15 2020, 1:58 PM

Doesn't this require a migration of existing data?

Doesn't this require a migration of existing data?

Yes and no.

Yes, but that's something not seen in the lister's code...
I do not know why we are inconsistent regarding model migration in that repository.

And no because, in any case, i will truncate the existing rows.
I will start the cran listing from scratch when this will be deployed ;)

ardumont updated this revision to Diff 9037.Jan 15 2020, 6:23 PM
ardumont edited the summary of this revision. (Show Details)

Reuse version variable

vlorentz accepted this revision.Jan 16 2020, 1:38 PM
This revision is now accepted and ready to land.Jan 16 2020, 1:38 PM
ardumont updated this revision to Diff 9038.Jan 16 2020, 1:44 PM

Plug to master branch