Page MenuHomeSoftware Heritage
Differential D2531

cran.lister: Version uid so we can list new package versions
ClosedPublic
Actions

Authored by ardumont on Jan 15 2020, 10:53 AM.

Details

Reviewers
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDLS767c4c6dc775: cran.lister: Version uid so we can list new package versions
Summary

Prior to this commit, the uid was the plain package's name.
Internal lister's mechanism would result in preventing to see new versions.
So it's important this uid is unique per version.

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 15 2020, 10:53 AM
ardumont mentioned this in D2524: cran.lister: Use CRAN's canonical url as origin url.Jan 15 2020, 10:54 AM
swh-public-ci added a comment.Jan 15 2020, 10:58 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/524/ for more details.

Harbormaster completed remote builds in B10102: Diff 9001.Jan 15 2020, 10:58 AM
ardumont updated this revision to Diff 9008.Jan 15 2020, 1:50 PM

Detach dependency from D2524

ardumont removed a parent revision: D2524: cran.lister: Use CRAN's canonical url as origin url.Jan 15 2020, 1:50 PM
swh-public-ci added a comment.Jan 15 2020, 1:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/525/ for more details.

Harbormaster completed remote builds in B10110: Diff 9008.Jan 15 2020, 1:53 PM
ardumont updated this revision to Diff 9011.Jan 15 2020, 1:56 PM
ardumont added a parent revision: D2524: cran.lister: Use CRAN's canonical url as origin url.

Add back checks on record's uid format

ardumont edited the summary of this revision. (Show Details)Jan 15 2020, 1:58 PM
swh-public-ci added a comment.Jan 15 2020, 2:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/527/ for more details.

Harbormaster completed remote builds in B10113: Diff 9011.Jan 15 2020, 2:01 PM
vlorentz added a subscriber: vlorentz.Jan 15 2020, 4:17 PM

Doesn't this require a migration of existing data?

ardumont added a comment.Jan 15 2020, 6:20 PM

Doesn't this require a migration of existing data?

Yes and no.

Yes, but that's something not seen in the lister's code...
I do not know why we are inconsistent regarding model migration in that repository.

And no because, in any case, i will truncate the existing rows.
I will start the cran listing from scratch when this will be deployed ;)

ardumont removed a parent revision: D2524: cran.lister: Use CRAN's canonical url as origin url.Jan 15 2020, 6:21 PM
ardumont updated this revision to Diff 9037.Jan 15 2020, 6:23 PM
ardumont edited the summary of this revision. (Show Details)

Reuse version variable

swh-public-ci added a comment.Jan 15 2020, 6:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/529/ for more details.

Harbormaster completed remote builds in B10140: Diff 9037.Jan 15 2020, 6:26 PM
vlorentz accepted this revision.Jan 16 2020, 1:38 PM
This revision is now accepted and ready to land.Jan 16 2020, 1:38 PM
ardumont updated this revision to Diff 9038.Jan 16 2020, 1:44 PM

Plug to master branch

swh-public-ci added a comment.Jan 16 2020, 1:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/530/ for more details.

Harbormaster completed remote builds in B10144: Diff 9038.Jan 16 2020, 1:47 PM
Closed by commit rDLS767c4c6dc775: cran.lister: Version uid so we can list new package versions (authored by ardumont). · Explain WhyJan 16 2020, 1:48 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLS767c4c6dc775: cran.lister: Version uid so we can list new package versions.
ardumont mentioned this in T2029: cran lister: Align lister to output list of tarballs per origin.Jan 17 2020, 12:35 PM

Revision Contents
Changeset List

PathSize
swh/
lister/
cran/
5 lines
tests/
7 lines

Diff 9039

View Options

swh/lister/cran/lister.py

Loading...
View Options

swh/lister/cran/tests/test_lister.py

Loading...
About · Developer information · Legal