Page MenuHomeSoftware Heritage

cran.loader: Fix parsing description file error
ClosedPublic

Authored by ardumont on Jan 9 2020, 3:19 PM.

Details

Summary

Fix error SWH-LOADER-CORE-1B [1]

UnicodeDecodeError is raised on some DESCRIPTION file.
Which makes the loading fail ungraciously.

[1] https://sentry.softwareheritage.org/share/issue/22e9853f1950442f96b25bdfa6cf09f4/

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10019
Build 14819: tox-on-jenkinsJenkins
Build 14818: arc lint + arc unit

Event Timeline

I would have loved to see a better ci message (with an explanation of the fixed error in there rather than depending on a 2-level external source, aka phab + sentry_ Otherwise OK.

This revision is now accepted and ready to land.Jan 10 2020, 5:12 PM

I would have loved to see a better ci message (with an explanation of the fixed error in there rather than depending on a 2-level external source, aka phab + sentry_ Otherwise OK.

look at the positive side, at least, you did not have to lookup through sentry ;)
yesterday, i had to for 2 other diffs with only the sentry id... i even had to use the dreadful mouse... that's something :D

I'll do better next time.