Page MenuHomeSoftware Heritage

cran.loader: Fix parsing description file error
ClosedPublic

Authored by ardumont on Thu, Jan 9, 3:19 PM.

Details

Summary

Fix error SWH-LOADER-CORE-1B [1]

UnicodeDecodeError is raised on some DESCRIPTION file.
Which makes the loading fail ungraciously.

[1] https://sentry.softwareheritage.org/share/issue/22e9853f1950442f96b25bdfa6cf09f4/

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Jan 9, 3:19 PM
ardumont edited the summary of this revision. (Show Details)Thu, Jan 9, 3:20 PM
douardda accepted this revision.Fri, Jan 10, 5:12 PM

I would have loved to see a better ci message (with an explanation of the fixed error in there rather than depending on a 2-level external source, aka phab + sentry_ Otherwise OK.

This revision is now accepted and ready to land.Fri, Jan 10, 5:12 PM
ardumont updated this revision to Diff 8938.Fri, Jan 10, 5:23 PM

Improve commit message

ardumont edited the summary of this revision. (Show Details)Fri, Jan 10, 5:24 PM

I would have loved to see a better ci message (with an explanation of the fixed error in there rather than depending on a 2-level external source, aka phab + sentry_ Otherwise OK.

look at the positive side, at least, you did not have to lookup through sentry ;)
yesterday, i had to for 2 other diffs with only the sentry id... i even had to use the dreadful mouse... that's something :D

I'll do better next time.

This revision was automatically updated to reflect the committed changes.