Page MenuHomeSoftware Heritage
Differential D2503

Fix support of VCSs whose HEAD branch is an alias.
ClosedPublic
Actions

Authored by vlorentz on Jan 7 2020, 5:46 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDX67987901379e: Fix support of VCSs whose HEAD branch is an alias.
Summary

Removing these methods causes the indexer to fall back to
the default (_try_get_head_generic), which already does
the right thing.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 7 2020, 5:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 7 2020, 5:46 PM
swh-public-ci added a comment.Jan 7 2020, 5:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/665/ for more details.

Harbormaster completed remote builds in B10000: Diff 8901.Jan 7 2020, 5:48 PM
vlorentz updated this revision to Diff 8902.Jan 7 2020, 5:49 PM

update comment

swh-public-ci added a comment.Jan 7 2020, 5:51 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/666/ for more details.

Harbormaster completed remote builds in B10001: Diff 8902.Jan 7 2020, 5:51 PM
olasd accepted this revision.Jan 7 2020, 5:51 PM
olasd added a subscriber: olasd.

All this logic should probably end up in swh.storage.algorithms, because I'm sure swh.web also has a subtly different algorithm to pick a default branch.

This revision is now accepted and ready to land.Jan 7 2020, 5:51 PM
Closed by commit rDCIDX67987901379e: Fix support of VCSs whose HEAD branch is an alias. (authored by vlorentz). · Explain WhyJan 9 2020, 3:35 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDX67987901379e: Fix support of VCSs whose HEAD branch is an alias..

Revision Contents
Changeset List

PathSize
swh/
indexer/
14 lines
tests/
5 lines

Diff 8919

View Options

swh/indexer/origin_head.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal