Details

Reviewers

douardda
olasd

Group Reviewers

Reviewers

Commits

rDLDBASEe81583980875: package.utils: Drop unneeded hashes from download computation

Summary

This should fix the current frequent issue on the debian loader [1]

loader retrieve badly the length information from the content-length header
We check for download size with that incorrect data
so download call function fails because it checks the local size and it's difference

all of this for the sha1_git computation which needs the length.
But we do not really need that hash (nor blake).

So simplifying by removing will actually fix [1]

[1] https://sentry.softwareheritage.org/share/issue/49d464bee7b24ad080598b32cd3eb9a8/

[2] https://sentry.softwareheritage.org/organizations/swh/issues/?project=9&query=is%3Aunresolved&sort=freq&statsPeriod=14d

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9930
Build 14671: tox-on-jenkins	Jenkins
Build 14670: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 20 2019, 1:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/294/ for more details.

Harbormaster completed remote builds in B9925: Diff 8833.Dec 20 2019, 1:34 PM

ardumont planned changes to this revision.Dec 20 2019, 1:45 PM

package.utils: Drop unneeded hashes from download computation

Drop the following computation hashes:

length (which was read from the content-length header, and sometimes it was wrongly read because of some missing header in the initial request)
sha1_git
blake2s256

ardumont retitled this revision from debian.loader: Fix wrong request content-length received to package.utils: Drop unneeded hashes from download computation.Dec 20 2019, 2:03 PM

ardumont edited the summary of this revision. (Show Details)

ardumont added projects: Core Loader, Debian loader.

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/295/ for more details.

Harbormaster completed remote builds in B9928: Diff 8836.Dec 20 2019, 2:04 PM

ardumont edited the summary of this revision. (Show Details)Dec 20 2019, 2:05 PM

Drop unneeded instructions about response.headers

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/296/ for more details.

Harbormaster completed remote builds in B9930: Diff 8838.Dec 20 2019, 2:17 PM

Just one tiny inline change, but looks good, thanks!