Differential D2472

Move load-deposit task creation code in the deposit-check private API endpoint
ClosedPublic
Actions

Authored by douardda on Dec 19 2019, 9:54 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP00cc60839e3a: Move load-deposit task creation code in the deposit-check private API endpoint

Summary

Also replace utils.origin_url_from() by a Deposit.origin_url property, and
ensure the archive file format of the uploaded file is supported.

The rename of invalid.tar.gz as invalid.gz is required for tests to pass
which should not be the case. It will be investigated in a later revision,
but for now we want tests to be green.

Depends on D2427

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 19 2019, 9:54 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 19 2019, 9:54 AM

douardda added a child revision: D2473: Always generate a zip file from uploaded archives.Dec 19 2019, 9:54 AM

Forgot a revision in this diff

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/226/ for more details.

Harbormaster completed remote builds in B9874: Diff 8777.Dec 19 2019, 9:58 AM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/228/ for more details.

Harbormaster completed remote builds in B9876: Diff 8779.Dec 19 2019, 10:02 AM

sounds about right.

Please, mind the remarks raised ;)

swh/deposit/api/private/deposit_read.py
179	As this should never change in the deposit's life cycle. We could probably have that as a model column in the deposit (that'd ease introspection). @moranegg: ^ Techically, that means: migration script (django) to alter the schema adding the column setting up the origin_url early early enough in the deposit's life cycle (first deposit which creates one). @both what do you think? (if we agree, that could go in another diff heh)
swh/deposit/client/__init__.py
113	heads up, that's the code giving you and me the hardtime when we discuss it in [1] [1] D2427#inline-16447