Page MenuHomeSoftware Heritage

Move origin_visit_get_random to the right place in the code and fix its docstring.
ClosedPublic

Authored by vlorentz on Dec 12 2019, 7:09 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
move-origin_visit_get_random
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9738
Build 14358: tox-on-jenkinsJenkins
Build 14357: arc lint + arc unit

Event Timeline

What's the right place?

swh/storage/storage.py
1502

might as well add its str type now (which is missing).

1505–1506

extra blank

1509

func:origin_visit_get?

swh/storage/storage.py
1509

(or whatever sphinx's docstring stanza to link to another method/function is)

lgtm

please check and fix the remarks though, they are small enough ;)

This revision is now accepted and ready to land.Dec 16 2019, 9:42 AM

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

ok

ah yes, i remember, it started as an origin retrieval (got even named origin_get_random initially).
It became a visit retrieval in the end and i forgot to move it ;)

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

ok

ah yes, i remember, it started as an origin retrieval (got even named origin_get_random initially).
It became a visit retrieval in the end and i forgot to move it ;)

I figured as much from the position and the docstrings before this diff

This revision was landed with ongoing or failed builds.Dec 16 2019, 2:09 PM
This revision was automatically updated to reflect the committed changes.