Differential D2425

Print a traceback in case a signal callback crashes.
ClosedPublic
Actions

Authored by vlorentz on Dec 10 2019, 4:44 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSCHf1b3f492a666: Print a traceback in case a signal callback crashes.

Summary

Celery silently eats errors happening in these functions.

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

signals-traceback

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9662
Build 14237: tox-on-jenkins	Jenkins
Build 14236: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 10 2019, 4:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 10 2019, 4:44 PM

vlorentz added a child revision: D2426: Initialize Sentry on Celery worker startup..Dec 10 2019, 4:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/319/ for more details.

Harbormaster completed remote builds in B9662: Diff 8581.Dec 10 2019, 4:46 PM

I guess the sentry-sdk stuff will mask/duplicate the exception if it fails, so you might want to guard that in another exception handler?

This revision now requires changes to proceed.Dec 11 2019, 2:28 PM

It's already masked anyway

print traceback in case sentry_sdk fails too.

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/331/ for more details.

Harbormaster completed remote builds in B9778: Diff 8690.Dec 16 2019, 2:22 PM

olasd accepted this revision.Dec 16 2019, 6:45 PM

This revision is now accepted and ready to land.Dec 16 2019, 6:45 PM

rebase

This revision was landed with ongoing or failed builds.Dec 16 2019, 6:55 PM

Closed by commit rDSCHf1b3f492a666: Print a traceback in case a signal callback crashes. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCHf1b3f492a666: Print a traceback in case a signal callback crashes..

Harbormaster failed remote builds in B9807: Diff 8720!Dec 16 2019, 6:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/335/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/335/console

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

celery_backend/

config.py

24 lines

Diff 8581

View Options

swh/scheduler/celery_backend/config.py

Print a traceback in case a signal callback crashes.ClosedPublicActions