Page MenuHomeSoftware Heritage

Print a traceback in case a signal callback crashes.
ClosedPublic

Authored by vlorentz on Dec 10 2019, 4:44 PM.

Details

Summary

Celery silently eats errors happening in these functions.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 10 2019, 4:44 PM
olasd requested changes to this revision.Dec 11 2019, 2:28 PM
olasd added a subscriber: olasd.

I guess the sentry-sdk stuff will mask/duplicate the exception if it fails, so you might want to guard that in another exception handler?

This revision now requires changes to proceed.Dec 11 2019, 2:28 PM

It's already masked anyway

vlorentz updated this revision to Diff 8690.Dec 16 2019, 2:20 PM

print traceback in case sentry_sdk fails too.

olasd accepted this revision.Dec 16 2019, 6:45 PM
This revision is now accepted and ready to land.Dec 16 2019, 6:45 PM
This revision was landed with ongoing or failed builds.Dec 16 2019, 6:55 PM
This revision was automatically updated to reflect the committed changes.