Paths

Table of Contentst

Differential D2418

Add gunicorn config script to initialize sentry-sdk based on envvars.
ClosedPublic
Actions

Authored by vlorentz on Dec 9 2019, 4:28 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1359: Add sentry support in every swh running service

Commits

rDCORE139e3d368cf8: Add gunicorn config script to initialize sentry-sdk based on envvars.

Summary

Depends on D2411.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 9 2019, 4:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2019, 4:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/375/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/375/console

Harbormaster failed remote builds in B9621: Diff 8537!Dec 9 2019, 4:32 PM

I don't know how to fix the tests. It's failing in the non-http envs, because I only install sentry-sdk (with the flask extra) for http.

fix deps

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/376/ for more details.

Harbormaster completed remote builds in B9632: Diff 8552.Dec 9 2019, 6:29 PM

vlorentz added a child revision: D2420: Import gunicorn config from swh-core..Dec 9 2019, 6:37 PM

Looks like phabricator messed up the stacking here. See comments on the other diff.

Before merging, could you add a rationale for using the post_fork hook as a comment or docstring here? I guess the point is to do the sentry sdk init as early as possible in every worker, but making that explicit would surely help the next person understand that.

This revision is now accepted and ready to land.Dec 10 2019, 12:03 PM

rebase

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/378/ for more details.

Harbormaster completed remote builds in B9640: Diff 8561.Dec 10 2019, 1:52 PM

add rational for using post_fork

This revision was landed with ongoing or failed builds.Dec 10 2019, 1:53 PM

Closed by commit rDCORE139e3d368cf8: Add gunicorn config script to initialize sentry-sdk based on envvars. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCORE139e3d368cf8: Add gunicorn config script to initialize sentry-sdk based on envvars..

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/379/ for more details.

Harbormaster completed remote builds in B9641: Diff 8562.Dec 10 2019, 1:54 PM

Harbormaster failed remote builds in B9642: Diff 8563!

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/380/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/380/console

vlorentz added a task: T1359: Add sentry support in every swh running service .Dec 11 2019, 3:41 PM

vlorentz mentioned this in D2429: Add sentry integration to swh-deposit.Dec 16 2019, 2:02 PM

Revision Contents
Changeset List

Path

Size

requirements-http.txt

1 line

swh/

core/

api/

gunicorn_config.py

44 lines

tests/

test_gunicorn.py

77 lines

Diff 8565

requirements-http.txt

Loading...

swh/core/api/gunicorn_config.py

Loading...

swh/core/api/tests/test_gunicorn.py

Loading...