Page MenuHomeSoftware Heritage

Make the CLI initialize sentry-sdk based on CLI options/envvars.
ClosedPublic

Authored by vlorentz on Dec 9 2019, 4:22 PM.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 9 2019, 4:22 PM
vlorentz updated this revision to Diff 8536.Dec 9 2019, 4:28 PM

fix tests of --help.

olasd requested changes to this revision.Dec 10 2019, 11:58 AM
olasd added a subscriber: olasd.

Could you set the sentry debug flags as hidden from the help text? That's _very_ verbose for a debugging option which most users will never turn on (or care about).

Can you make sure that the sentry logging integration works well when initialized /before/ we configure the logging framework itself?

This revision now requires changes to proceed.Dec 10 2019, 11:58 AM
vlorentz updated this revision to Diff 8560.Dec 10 2019, 1:44 PM

Hide --sentry-debug.

In D2411#57190, @olasd wrote:

Could you set the sentry debug flags as hidden from the help text? That's _very_ verbose for a debugging option which most users will never turn on (or care about).

Done.

Can you make sure that the sentry logging integration works well when initialized /before/ we configure the logging framework itself?

I just checked and it does.

olasd accepted this revision.Dec 10 2019, 1:49 PM
This revision is now accepted and ready to land.Dec 10 2019, 1:49 PM