Page MenuHomeSoftware Heritage

vault: Fix tests data initialization after git loader api changes
ClosedPublic

Authored by ardumont on Dec 9 2019, 4:22 PM.

Details

Summary

Note:
Build expected to fail for now (need to tag swh-loader-git)

Related to D2400
Related to T2134

Test Plan

tox

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 9 2019, 4:22 PM
anlambert accepted this revision.Dec 9 2019, 5:33 PM
anlambert added a subscriber: anlambert.

Looks good to me !

swh/vault/tests/test_cookers.py
189–191

Maybe you can write

git_loader(swh_storage, str(rp)).load()

to gain a couple of lines, but that's pure nitpicking.

This revision is now accepted and ready to land.Dec 9 2019, 5:33 PM