Differential D2412

vault: Fix tests data initialization after git loader api changes
ClosedPublic
Actions

Authored by ardumont on Dec 9 2019, 4:22 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDVAU7bebb14a6ff1: Fix tests data initialization after git loader api changes

Summary

Note:
Build expected to fail for now (need to tag swh-loader-git)

Related to D2400
Related to T2134

Test Plan

tox

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 9 2019, 4:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2019, 4:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tox/90/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tox/90/console

Harbormaster failed remote builds in B9614: Diff 8530!Dec 9 2019, 4:24 PM

Looks good to me !

swh/vault/tests/test_cookers.py
189–191	Maybe you can write git_loader(swh_storage, str(rp)).load() to gain a couple of lines, but that's pure nitpicking.

This revision is now accepted and ready to land.Dec 9 2019, 5:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DVAU/job/tox/91/ for more details.

Harbormaster completed remote builds in B9614: Diff 8530.Dec 10 2019, 11:34 AM

Closed by commit rDVAU7bebb14a6ff1: Fix tests data initialization after git loader api changes (authored by ardumont). · Explain WhyDec 10 2019, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDVAU7bebb14a6ff1: Fix tests data initialization after git loader api changes.

Revision Contents
Changeset List

Path

Size

swh/

vault/

tests/

conftest.py

5 lines

test_cookers.py

117 lines

Diff 8555

View Options

swh/vault/tests/conftest.py