Page MenuHomeSoftware Heritage
Differential D2400

git: Unify loaders constructor + register worker (tasks, cli)
ClosedPublic
Actions

Authored by ardumont on Dec 5 2019, 3:44 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDG6aab90016a84: tasks: Use celery's shared_task decorator
rDLDG63a94e997944: tests: Migrate to pytest-mock's fixture
rDLDG402b1e513eca: loader.git: Register git worker
rDLDG1b550e3e3b5b: tasks: Rename task according to production
rDLDG546ee4a31c85: git: Unify loaders constructor
Summary

With this commit, we stop passing parameters to the load method. We pass those
parameters to the loader's constructor.

  • tasks: Rename task according to production
  • loader.git: Register git worker

Related to T2134

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 5 2019, 3:44 PM
swh-public-ci added a comment.Dec 5 2019, 3:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/104/ for more details.

Harbormaster completed remote builds in B9534: Diff 8455.Dec 5 2019, 3:46 PM
ardumont mentioned this in T2134: loader: Implement uniform loading CLI.Dec 6 2019, 10:04 AM
anlambert accepted this revision.Dec 6 2019, 1:24 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/loader/git/__init__.py
9 ↗(On Diff #8455)

s/Mapping/Dict/

This revision is now accepted and ready to land.Dec 6 2019, 1:24 PM
anlambert added inline comments.Dec 6 2019, 1:37 PM
swh/loader/git/tests/test_tasks.py
6

You should use the mocker fixture from pytest-mock instead

anlambert mentioned this in D2399: mercurial: Unify loader constructor + register worker (tasks, cli).Dec 6 2019, 1:46 PM
ardumont updated this revision to Diff 8495.Dec 6 2019, 3:05 PM
  • tests: Migrate to pytest-mock's fixture
  • tasks: Use celery's shared_task decorator
ardumont updated this revision to Diff 8496.Dec 6 2019, 3:06 PM

Adapt according to review (missed)

swh-public-ci added a comment.Dec 6 2019, 3:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/105/ for more details.

Harbormaster completed remote builds in B9578: Diff 8495.Dec 6 2019, 3:07 PM
swh-public-ci added a comment.Dec 6 2019, 3:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/106/ for more details.

Harbormaster completed remote builds in B9579: Diff 8496.Dec 6 2019, 3:08 PM
Closed by commit rDLDG546ee4a31c85: git: Unify loaders constructor (authored by ardumont). · Explain WhyDec 6 2019, 3:56 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDG546ee4a31c85: git: Unify loaders constructor.
ardumont added a commit: rDLDG1b550e3e3b5b: tasks: Rename task according to production.
ardumont added a commit: rDLDG402b1e513eca: loader.git: Register git worker.
ardumont added a commit: rDLDG63a94e997944: tests: Migrate to pytest-mock's fixture.
ardumont added a commit: rDLDG6aab90016a84: tasks: Use celery's shared_task decorator.
ardumont mentioned this in D2407: Fix tests data initialization after git loader api changes.Dec 6 2019, 5:38 PM
ardumont mentioned this in D2412: vault: Fix tests data initialization after git loader api changes.Dec 9 2019, 4:22 PM
ardumont mentioned this in rDVAU7bebb14a6ff1: Fix tests data initialization after git loader api changes.Dec 10 2019, 11:38 AM

Revision Contents
Changeset List

PathSize
swh/
loader/
git/
3 lines
38 lines
24 lines
19 lines
tests/
24 lines
7 lines
11 lines

Diff 8504

View Options

swh/loader/git/converters.py

Loading...
View Options

swh/loader/git/from_disk.py

Loading...
View Options

swh/loader/git/loader.py

Loading...
View Options

swh/loader/git/tasks.py

Loading...
View Options

swh/loader/git/tests/test_from_disk.py

Loading...
View Options

swh/loader/git/tests/test_loader.py

Loading...
View Options

swh/loader/git/tests/test_tasks.py

Loading...
About · Developer information · Legal