The 'offset' parameter of the origin search API is deprecated.
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- paginate-link-header
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9481 Build 13938: Cypress tests for swh-web diffs Jenkins Build 13937: tox-on-jenkins Jenkins Build 13936: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/817/ for more details.
Apart a couple of nitpicks to handle, looks good !
swh/web/assets/src/bundles/browse/origin-search.js | ||
---|---|---|
11–14 | If the variable is not going to get modified, it is better to declare it with const instead of let | |
131–144 | Here I would rather write: let response; fetch(searchUrl) .then(handleFetchError) .then(resp => { response = resp; return resp.json(); }) .then(data => { Feels more readable to me. | |
147 | s/backword/backward/ | |
swh/web/tests/data.py | ||
188 | You should add a visit to each origin (pointing to the empty snapshot for instance). When executing cypress tests for origins search, the api/1/origin/(origin_url)/visit/latest/ endpoint will be |
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/826/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/424/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/827/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/425/ for more details.