Page MenuHomeSoftware Heritage

Build origin search regexps server-side.
ClosedPublic

Authored by vlorentz on Dec 3 2019, 2:24 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Summary

Motivations:

  • Makes behavior of the API closer to what we will have when it will use swh-search
  • A step toward not accepting arbitrary regexps from the network.
  • Less code (itertools.permutations instead of our own JS implementation)
  • More tests.

Depends on D2378.

Diff Detail

Repository
rDWAPPS Web applications
Branch
regexp-server-side
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9484
Build 13946: Cypress tests for swh-web diffsJenkins
Build 13945: tox-on-jenkinsJenkins
Build 13944: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 3 2019, 2:24 PM
anlambert accepted this revision.Dec 3 2019, 3:03 PM
anlambert added a subscriber: anlambert.

Looks good, thanks !

This revision is now accepted and ready to land.Dec 3 2019, 3:03 PM
vlorentz closed this revision.Dec 3 2019, 3:13 PM

Landed as 8b161d7c5f5943bcd880cd9a3953d81e0fa91a74.