- testing missing, add and get methods on revision_metadata
Closes T741
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T741: add revision_metadata logic to storage
- Commits
- rDSTOC9d416d3fec93: Added revision_metadata table and methods into storage
R65:9d416d3fec93: Added revision_metadata table and methods into storage
rDSTO9d416d3fec93: Added revision_metadata table and methods into storage
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Sounds fine :)
We should maybe try to avoid duplicating values in tests.
The file is big enough as it is...
| sql/swh-func.sql | ||
|---|---|---|
| 2110 | indentation seems off here. | |
| swh/storage/tests/test_storage.py | ||
| 3233 | As this is pretty long, maybe find a way to avoid duplication in those data (same goes for the next test) For example: 'translated_metadata': metadata_rev['translated_metadata'] | |
| swh/storage/tests/test_storage.py | ||
|---|---|---|
| 3233 |
i meant next tests :) | |