Page MenuHomeSoftware Heritage
Differential D2346

Implement origin lookup by sha1
ClosedPublic
Actions

Authored by olasd on Nov 22 2019, 6:29 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2045: add support for reverse lookup from swh:1:ori:... PIDs to origin URLs
Commits
rDSTOC2cac3392eb49: Implement origin lookup by sha1
rDSTO2cac3392eb49: Implement origin lookup by sha1
Summary

Close T2045.

Test Plan

tox + index created on the production database yields sensible results

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 22 2019, 6:29 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 22 2019, 6:29 PM
swh-public-ci added a comment.Nov 22 2019, 6:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/808/ for more details.

Harbormaster completed remote builds in B9345: Diff 8074.Nov 22 2019, 6:32 PM
ardumont accepted this revision.Nov 22 2019, 6:34 PM
ardumont added a subscriber: ardumont.

sounds good.

You might want to transform the type comment into type but meh ;)

This revision is now accepted and ready to land.Nov 22 2019, 6:34 PM
olasd updated this revision to Diff 8075.Nov 22 2019, 6:35 PM

Unsuck docstrings

swh-public-ci added a comment.Nov 22 2019, 6:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/809/ for more details.

Harbormaster completed remote builds in B9346: Diff 8075.Nov 22 2019, 6:38 PM
vlorentz added a subscriber: vlorentz.Nov 22 2019, 7:57 PM

Nitpick: should be named origin_get_by_sha1

olasd updated this revision to Diff 8086.Nov 25 2019, 3:13 PM

Rename endpoint to origin_get_by_sha1

swh-public-ci added a comment.Nov 25 2019, 3:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/810/ for more details.

Harbormaster completed remote builds in B9362: Diff 8086.Nov 25 2019, 3:16 PM
olasd updated this revision to Diff 8087.Nov 25 2019, 3:18 PM

Fix typo in SQL migration

swh-public-ci added a comment.Nov 25 2019, 3:21 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/811/ for more details.

Harbormaster completed remote builds in B9363: Diff 8087.Nov 25 2019, 3:21 PM
Closed by commit rDSTO2cac3392eb49: Implement origin lookup by sha1 (authored by olasd). · Explain WhyNov 25 2019, 3:30 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDSTO2cac3392eb49: Implement origin lookup by sha1.
olasd added a commit: rDSTOC2cac3392eb49: Implement origin lookup by sha1.Jan 16 2020, 5:22 PM
vlorentz mentioned this in T1731: Intrinsic identifiers for origins.Jan 22 2020, 2:18 PM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
10 lines
swh/
storage/
api/
3 lines
7 lines
8 lines
11 lines
19 lines
sql/
2 lines
1 line
19 lines
tests/
19 lines

Diff 8088

View Options

sql/upgrades/144.sql

Loading...
View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/converters.py

Loading...
View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/30-swh-schema.sql

Loading...
View Options

swh/storage/sql/60-swh-indexes.sql

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal