It's currently untested and it's not really clear how to test this without duplicating the "potential" test in each lister.
Given that, i would not be shocked if for once, you push that as is.

Having said that, it comes to mind that there might be one lister which seems simpler than the other and use directly requests: cgit lister.
Although it does not use that __version__, you could make it so and add a test for it.

What do you think?

And thanks for fixing it.

Cheers,

Add trivial version test

This revision is now accepted and ready to land.Nov 22 2019, 12:04 PM

olasd requested review of this revision.Nov 22 2019, 12:04 PM

olasd retitled this revision from [WIP] Use pkg_resources to get the package version instead of vcversioner to Use pkg_resources to get the package version instead of vcversioner.

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/496/ for more details.

Harbormaster completed remote builds in B9320: Diff 8052.Nov 22 2019, 12:07 PM

ardumont accepted this revision.Nov 22 2019, 12:08 PM

This revision is now accepted and ready to land.Nov 22 2019, 12:08 PM

olasd added a child revision: D2339: Use a uniform User-Agent on all listers.Nov 22 2019, 1:13 PM

Rebase

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/498/ for more details.

Harbormaster completed remote builds in B9329: Diff 8061.Nov 22 2019, 3:53 PM

Closed by commit rDLS62dc4dc257fe: Use pkg_resources to get the package version instead of vcversioner (authored by olasd). · Explain WhyNov 22 2019, 4:15 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLS62dc4dc257fe: Use pkg_resources to get the package version instead of vcversioner.