Page MenuHomeSoftware Heritage

Use pkg_resources to get the package version instead of vcversioner
ClosedPublic

Authored by olasd on Nov 21 2019, 6:26 PM.

Details

Summary

Planned changes because I need to figure out where to put a user-agent
check before landing this.

T2105.

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 21 2019, 6:26 PM
olasd planned changes to this revision.Nov 21 2019, 6:26 PM
olasd edited the summary of this revision. (Show Details)Nov 21 2019, 6:27 PM
ardumont accepted this revision.Nov 22 2019, 9:55 AM
ardumont added a subscriber: ardumont.

It's currently untested and it's not really clear how to test this without duplicating the "potential" test in each lister.
Given that, i would not be shocked if for once, you push that as is.

Having said that, it comes to mind that there might be one lister which seems simpler than the other and use directly requests: cgit lister.
Although it does not use that __version__, you could make it so and add a test for it.

What do you think?

And thanks for fixing it.

Cheers,

olasd updated this revision to Diff 8052.Nov 22 2019, 12:04 PM

Add trivial version test

This revision is now accepted and ready to land.Nov 22 2019, 12:04 PM
olasd requested review of this revision.Nov 22 2019, 12:04 PM
olasd retitled this revision from [WIP] Use pkg_resources to get the package version instead of vcversioner to Use pkg_resources to get the package version instead of vcversioner.
ardumont accepted this revision.Nov 22 2019, 12:08 PM
This revision is now accepted and ready to land.Nov 22 2019, 12:08 PM
olasd updated this revision to Diff 8061.Nov 22 2019, 3:50 PM

Rebase