service: Fix possible error when looking latest origin visit
ClosedPublic
Actions

Authored by anlambert on Nov 12 2019, 5:13 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS0fc6ef27d2d2: service: Fix possible error when looking latest origin visit

Summary

When an origin did not get visited yet, an error was raised when calling
the service.lookup_origin_visit_latest function.

Also add a test to ensure the /origin/visit/latest/ endpoint of the web api
returns a 404 status code when no visit exists for an origin.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 12 2019, 5:13 PM

Shouldn't the new test code be in its own function?

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/364/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/364/console

Harbormaster failed remote builds in B8960: Diff 7784!Nov 12 2019, 5:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/763/ for more details.

In D2256#53095, @vlorentz wrote:

Shouldn't the new test code be in its own function?

Indeed, seems better to add a new test function here.

Update: Move new test implementation in a dedicated function

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/764/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/365/ for more details.

Harbormaster completed remote builds in B8961: Diff 7785.Nov 12 2019, 5:32 PM

ardumont accepted this revision.Nov 12 2019, 6:29 PM

This revision is now accepted and ready to land.Nov 12 2019, 6:29 PM

vlorentz accepted this revision.Nov 12 2019, 10:38 PM

Closed by commit rDWAPPS0fc6ef27d2d2: service: Fix possible error when looking latest origin visit (authored by anlambert). · Explain WhyNov 13 2019, 10:54 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS0fc6ef27d2d2: service: Fix possible error when looking latest origin visit.

Revision Contents
Changeset List

Path

Size

swh/

web/

common/

service.py

3 lines

tests/

api/

views/

test_origin.py

16 lines

Diff 7801

View Options

swh/web/common/service.py