Depends on D2222
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDCIDX01f1c385d0a1: tests: update/add copyright/license headers
rDCIDX5150eea140ed: tests: migrate storage tests to pytest
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Branch
- tests
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 8847 Build 12909: tox-on-jenkins Jenkins Build 12908: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/646/ for more details.
Why not inheritance instead of so many assigments? (Also, non-methods with a "self" argument...)
And I would prefer explicitly skipping/removing tests in each class than whitelisting which ones run
swh/indexer/tests/storage/conftest.py | ||
---|---|---|
75 | bad name (_w_) | |
swh/indexer/tests/storage/generate_data_test.py | ||
90 | Why an uuid instead of os.random? | |
107 | same |
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/648/ for more details.
swh/indexer/tests/storage/generate_data_test.py | ||
---|---|---|
90 | because the uuid hypothesis generator is used in gen_content_mimetypes() I guess, so I stuck to it without really thinking about it. And it's a simple way of generating a small random string/bytes. Is there a problem with using uuid there? | |
swh/indexer/tests/storage/test_in_memory.py | ||
1 | not really here (but I could have added them obviously) but I do in test_storage.py for sure |
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/649/ for more details.
You missed one of my comments:
swh/indexer/tests/storage/generate_data_test.py | ||
---|---|---|
90 |
no, it just doesn't make sense |
Refactor the tests to prevent these ugly injected functions
doing so, also break the TestIndexerStorageOthers class in pieces
(one for each covered endpoint type).
swh/indexer/tests/storage/generate_data_test.py | ||
---|---|---|
90 | why so? uuid is a perfectly valid way of generating a small random piece of bytes. Also, it's not clear if this really is a blocker for you or not. |
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/650/ for more details.
swh/indexer/tests/storage/conftest.py | ||
---|---|---|
113 | ah, lol, wrong file, i meant for the test_api_client for example. |
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/652/ for more details.
swh/indexer/tests/storage/conftest.py | ||
---|---|---|
113 | in these files, it is indeed a local overload of the given fixture. |
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/654/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/655/ for more details.