Why this change?

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/334/ for more details.

In D2226#52407, @vlorentz wrote:

Why this change?

To remove a low hanging fruit that is cluttering the PostgreSQL monitoring/logs.

Why is this cluttering logs?
This code should only run once at the beginning of a connection, and connections are long-lived

In D2226#52414, @vlorentz wrote:

Why is this cluttering logs?
This code should only run once at the beginning of a connection, and connections are long-lived

The code runs every time we instantiate a Db object, not at the beginning of a connection.

We instantiate a Db object every time we do get_conn.

We do get_conn/put_conn on pretty much every request.

I agree that this should also change to not run when the type has already been registered on the connection object.

I agree that this should also change to not run when the type has already been registered on the connection object.

I think that's a better fix than removing the request.

As @douardda said: "better safe then sorry..."

In D2226#52416, @vlorentz wrote:

I agree that this should also change to not run when the type has already been registered on the connection object.

I think that's a better fix than removing the request.

As @douardda said: "better safe then sorry..."

Hrm. The OIDs of built-in types are part of the PostgreSQL binary protocol and will never change. Basically all wrappers around libpq hardcode OID numbers. This query is really just a waste of a TCP round trip.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/335/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/335/console

I've tried doing the adaptation only once in a naive way, but Computer Says No. :(

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/336/ for more details.