Page MenuHomeSoftware Heritage

Use unbound methods as callbacks for confluent-kafka.
ClosedPublic

Authored by vlorentz on Oct 30 2019, 11:50 AM.

Details

Summary

Using bound methods causes consumer.poll() to return None under some
(apparently deterministic but unclear) conditions.

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8704
Build 12674: tox-on-jenkinsJenkins
Build 12673: arc lint + arc unit

Event Timeline

Tests are broken because swh-storage needs a release (ping @douardda )

This revision is now accepted and ready to land.Oct 30 2019, 11:59 AM
This revision was landed with ongoing or failed builds.Oct 30 2019, 12:13 PM
This revision was automatically updated to reflect the committed changes.